I spent a lot of time fixing makefiles these past weeks. It seems there isn’t much about debugging makefiles on the internet, so I’ll place this here as a way to collate a bunch of StackOverflow posts.
VG has quite a few dependencies and lots of individual code modules, and a serial make build takes about 20 minutes. Travis CI builds are even worse, taking over 30 minutes at times (maybe something to do with virtualization performance?). Early on we had parallel builds working, but when I introduced
vg deconstruct I inadvertently (and unknowingly) broke them. Our parallel builds would work for a while and fail out, forcing us to finish each one with a serial run.
All of our issues came down to missing
Make dependencies for various targets. To debug this, I went through each file and made sure that the
#include lines matched the dependencies in the Makefile. I also had some ghost targets/dependencies, where I had mispelled a dependency and Make had never complained. Once I’d made sure all the includes were set as dependencies, I would kick off a parallel build and wait to see the dreaded
#Error on the command line.
There has got to be a better way to do this…
But I haven’t found it yet. Sometimes running
make -n (dry run) would help, as I could see what was happening without all the debug messages from packages being built. I could probably also write a little BASH/Python to find the include/dependency discrepancies, but I’ve been distracted with other things.
Telling Make what to make of Makefile lines
I kept getting this ambiguous error that my make lines weren’t make processes, so they were being executed in serial. I just added a
+ to each rule of the vg source code to fix this. Thanks again, StackOverflow!
Ensure Make target is a file
I had originally used a dummy target, but this prevented Make from ever thinking that the build was complete. I think I’ll avoid things like
make all and stick to real targets from now on. I even use hidden files for pre-build dependencies such as setting up folders (e.g.
touching a file named
Build executable off of the library, not a crap ton of object files
I had originally patched up vg to build the executable on a ton of object files that were also bundled up into a library for other to use. This was pretty silly on my part. By making the executable depend on the library and the library dependent on the object files, I made the build even quicker and ensured that the binary and library contained identical code. I should have done this in the first place but didn’t yet know any better.
vg used to take 20 minutes to build in serial and up to ten to build in parallel. I’m consistently getting builds under four minutes with
make -j 4, both on my virtual machine on a Macbook Pro and my quad-core desktop. Incremental builds are fixed again, and everyone is much happier.